Site Tools


contribute

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
contribute [2017/12/08 21:48]
mwichmann
contribute [2018/01/08 09:14]
rzr [Commit messages]
Line 33: Line 33:
 It is understood that this is a bit of a burden: if you have more than can be expressed in a single small patch, it means juggling several patches and keeping track of the flow as they merge, the gerrit workflow for multiple related patches is not like some projects where you split into 27 related but independent patches and send them all at once to an email list for review. ​ Each system has different characteristics. It is understood that this is a bit of a burden: if you have more than can be expressed in a single small patch, it means juggling several patches and keeping track of the flow as they merge, the gerrit workflow for multiple related patches is not like some projects where you split into 27 related but independent patches and send them all at once to an email list for review. ​ Each system has different characteristics.
  
 +==== Earlier is better ====
  
 +Related to the previous, it is not wise to gather up a huge change and submit it all at once with the note "we need this merged because a product we are releasing in a month depends on it"​. ​ If you need a change merged, get it started as early as possible to get people used to the idea, sending small pieces to edge towards the goal so you don't risk having the big change rejected. ​ If you've gotten most of what you need merged, and something doesn'​t make it in, the patches you have to keep track of locally to add to "​official IoTivity"​ will be much smaller and more manageable.
 ==== Commit messages ==== ==== Commit messages ====
  
Line 53: Line 55:
  
   Suggested-by:​ ...   Suggested-by:​ ...
-  Credit-to: Name of person <​that@helped.this>​+  Credit-to: Name of person <​that@who.proposed.this.first>​ 
 +  Thanks-to: Name of person <​that@helped.somehow.on.this
 +  Reported-by:​ Name of person <​that@reported.problem>
   Bug-XYZ: $url (downstream projects)   Bug-XYZ: $url (downstream projects)
   Origin: $url (where patch is coming from)   Origin: $url (where patch is coming from)
contribute.txt · Last modified: 2018/01/08 09:14 by rzr